[PATCH] test-mq-subrepo-svn: enable for Windows

Adrian Buehlmann adrian at cadifra.com
Fri Jun 8 04:02:10 CDT 2012


On 2012-06-08 10:33, Eduard-Cristian Stefan wrote:
> On Fri, Jun 8, 2012 at 11:17 AM, Adrian Buehlmann <adrian at cadifra.com> wrote:
>> I haven't tried this patch myself, but I know Eduard-Cristian enough to
>> trust him that this patch can be taken.
> 
> I can make mistakes, and too many failures can erode your credibility also.

I did read your patch, just haven't tried it. Being honest.

>From reading your patch, it looks reasonable to me and harmless enough
to take it. I don't think it is needed to agonize that long over this patch.

Now, in the mean time, I have started my 32-bit Ubuntu Linux in a VM,
and tried applying your patch.

It first failed to apply (doing copy & paste and then import dialog of
TortoiseHg, which usually works fine), then I took the attached patch
file, which applied cleanly.

Then I ran that test on Ubuntu, which revealed that subversion was not
installed in that VM. So I installed it.

Then I ran

  python run-tests.py test-mq-subrepo-svn.t

and

  python run-tests.py test-check-code*

both of which passed.

>> As a side note to Eduard-Cristian: mercurial-devel is a bit pickier than
>> the TortoiseHg developer mailing list. So here, people expect not to see
>> patches as attachments in patch emails. Using the email dialog in
>> TortoiseHg to send patches to mercurial-devel should work just fine. Or
>> use "hg email" in a command-line cmd.exe.
> 
> I know, but I hadn't a chance to send them from home,
> and I have a truly paranoid firewall at work.
> I prefer to send them as such at least for the feedback, and resend them
> properly once I got back at home.

Ok. But please try sending without attachment anyway next time. If it
fails, we will tell you. I think emails with attachments aren't received
that well on mercurial-devel, although, from my side, I don't have a
problem with patches in attachments.



More information about the Mercurial-devel mailing list