[PATCH 6 of 8] obsolete: exchange obsolete marker over pushkey

Patrick Mézard patrick at mezard.eu
Fri Jun 8 09:02:55 CDT 2012


Le 08/06/12 15:30, Augie Fackler a écrit :
> 
> On Jun 7, 2012, at 12:56 PM, Patrick Mézard wrote:
> 
>> Over HTTP, pushkey sends all the data in split HTTP headers
> 
> Pushkey pushes don't use POST? I thought for sure they did.

Kind of, yes, they put the pushkey data in the HTTP POST request headers.

See httprepo.py _callstream() here:

  http://selenic.com/hg/file/7b15dd9125b3/mercurial/httprepo.py#l74

Request payload should be passed as args['data']. For some reason, it is reset in pushkey case, but this is a bit unrelated. The pushkey call is here:

  http://selenic.com/hg/file/525fdb738975/mercurial/wireproto.py#l234

Yielded dictionary contains no data, so there is no intent to pass the pushkey content in request body.

--
Patrick Mézard


More information about the Mercurial-devel mailing list