[PATCH 01 of 14] tests: roll test-committer.t into test-commit.t

[Kevin Bullock]

On Jun 8, 2012, at 12:02 PM, Adrian Buehlmann wrote:

> On 2012-06-08 18:07, Martin Geisler wrote:
>>> diff --git a/tests/test-commit.t b/tests/test-commit.t
>>> --- a/tests/test-commit.t
>>> +++ b/tests/test-commit.t
>>> @@ -106,7 +106,8 @@
>>>   [255]
>>> 
>>>   $ cd ..
>>> -
>>> +  $ pwd
>>> +  $TESTTMP
>> 
>> Is this there on purpose? I don't see what it tests.
>> 
> 
> It is on purpose.
> 
> Some tests had errors with incorrectly matched cd of the sort
> 
>   $ cd foo
>   ...
>   $ cd ..
>   ...
>   $ cd ..
> 
> which resultet in cd'ing way too high up. That check makes sure that
> this doesn't happen again if someone edits the test later on.


Others may have a different opinion on this, but this is the sort of thing I'd put in while combining the tests, then take out again before submitting the patch.

pacem in terris / мир / शान्ति / ‎‫سَلاَم‬ / 平和
Kevin R. Bullock

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://selenic.com/pipermail/mercurial-devel/attachments/20120608/922de742/attachment.html>