[PATCH 01 of 14] tests: roll test-committer.t into test-commit.t
Mads Kiilerich
mads at kiilerich.com
Fri Jun 8 16:37:49 CDT 2012
Martin Geisler wrote, On 06/08/2012 06:07 PM:
> Adrian Buehlmann <adrian at cadifra.com> writes:
>
>> # HG changeset patch
>> # User Adrian Buehlmann <adrian at cadifra.com>
>> # Date 1339161065 -7200
>> # Node ID d62774e5fdbcf4dd9a170c2ee2efb4dbbc4d7ffc
>> # Parent 35292e67674593ae5a32572eaf7916ab3b09bcda
>> tests: roll test-committer.t into test-commit.t
> I would like to question whether this is a good idea.
...
I doubt there is any speed gain from merging tests as long as there is
no reuse. Running two test files instead of one is probably not more
expensive than a single hg / python invocation - I can't be bothered to
measure it.
Having too many small test files do however also have a maintenance
overhead. The merges done in this series are 'obviously' good.
(I agree that reuse of setup code and tweaking existing test cases
instead of creating new ones has a cost and a risk and should be used
carefully - but in some cases it would be worth it.)
I think I would push the whole series to crew if it wasn't for the
"pwd"s. Is it ok that I remove them?
/Mads
More information about the Mercurial-devel
mailing list