[PATCH 01 of 14] tests: roll test-committer.t into test-commit.t
Adrian Buehlmann
adrian at cadifra.com
Fri Jun 8 17:01:43 CDT 2012
On 2012-06-08 23:37, Mads Kiilerich wrote:
> Martin Geisler wrote, On 06/08/2012 06:07 PM:
>> Adrian Buehlmann <adrian at cadifra.com> writes:
>>
>>> # HG changeset patch
>>> # User Adrian Buehlmann <adrian at cadifra.com>
>>> # Date 1339161065 -7200
>>> # Node ID d62774e5fdbcf4dd9a170c2ee2efb4dbbc4d7ffc
>>> # Parent 35292e67674593ae5a32572eaf7916ab3b09bcda
>>> tests: roll test-committer.t into test-commit.t
>> I would like to question whether this is a good idea.
> ...
>
> I doubt there is any speed gain from merging tests as long as there is
> no reuse. Running two test files instead of one is probably not more
> expensive than a single hg / python invocation - I can't be bothered to
> measure it.
>
> Having too many small test files do however also have a maintenance
> overhead. The merges done in this series are 'obviously' good.
>
> (I agree that reuse of setup code and tweaking existing test cases
> instead of creating new ones has a cost and a risk and should be used
> carefully - but in some cases it would be worth it.)
>
> I think I would push the whole series to crew if it wasn't for the
> "pwd"s. Is it ok that I remove them?
Thanks very much for the offer. But I think I'm not so confident about
the mergers any more. Let's hold on with them.
And yeah, the pwd's turned out to be a bad idea.
Mads, if you agree, could you please push (in that order):
test-revert: enable for Windows
test-log: enable for Windows
test-import: remove unneeded chmod call
test-import: enable for Windows
tests/run-tests: use $TMP on Windows (issue3490)
I think these are ok for pushing.
tests/hghave: implement #if true / #if false
is probably also ok, but Augie was not so super happy with the texts.
Thanks to all.
More information about the Mercurial-devel
mailing list