[PATCH 2 of 2] test-convert-git: remove the read-only attribute of repository files
Eduard-Cristian Stefan
alexandrul.ct at gmail.com
Sat Jun 9 08:55:49 CDT 2012
On 2012-06-09 15:34, Mads Kiilerich wrote:
>>>> + > os.remove(path)
>>>> + > break
>>>> + > except:
>>>> + > continue
>>>
>>> Why this blank except/continue? What problem will it hide ... and why is that not a problem?
>>
>> Will eat any exceptions in the hope that some other file
>> in the git repository will be succesfully deleted
>> so the repository will be in an invalid state
>> (as expected in the last part of the test).
>
> - but without this change. If you think it is a good idea then it is a separate change with its own rationale.
I will let it rest in peace for now.
Thank you very much,
Eduard
More information about the Mercurial-devel
mailing list