[PATCH] run-test: replace backslashes in TESTDIR

Mads Kiilerich mads at kiilerich.com
Sat Jun 9 10:17:44 CDT 2012


Mads Kiilerich wrote, On 06/04/2012 03:20 AM:
> Adrian Buehlmann wrote, On 06/03/2012 07:40 PM:
>> # HG changeset patch
>> # User Adrian Buehlmann<adrian at cadifra.com>
>> # Date 1338744923 -7200
>> # Node ID 81f15de595760f3592e34b8d97c5f9ef2e760a80
>> # Parent  7b460b49bf7b75c5a4ab444915c52802c9f97f33
>> run-test: replace backslashes in TESTDIR
>>
>> This may cause troubles in MSYS on Windows.
>
> pushed to crew default, thanks.

- as http://selenic.com/repo/hg/rev/ac3e063eebf1 .

It looked good and innocent, but it happens to cause troubles in MSYS on 
Windows.

For example test-ssh.t will fail because msys see a "something 
c:/something" path and assume it is a posix path list and translate it 
to the windows style which is "something C;c:/MinGW/.../something". 
(http://www.mingw.org/wiki/Posix_path_conversion )

What trouble did it fix? AFAICS it would be better to back it out.

We could probably apply some workarounds like using "\"python\" 
\"$TESTDIR..." to avoid msys being too clever, but I would prefer not to 
do so if we don't have to.

/Mads


More information about the Mercurial-devel mailing list