[PATCH cooking] tests/run-tests: avoid C:/ in arguments

Adrian Buehlmann adrian at cadifra.com
Sun Jun 10 08:52:46 CDT 2012


On 2012-06-10 15:18, Mads Kiilerich wrote:
> Adrian Buehlmann wrote, On 06/10/2012 12:11 PM:
>> # HG changeset patch
>> # User Adrian Buehlmann <adrian at cadifra.com>
>> # Date 1339290359 -7200
>> # Node ID 2774576dee4de16c11e8904fbe40e13116c82a7b
>> # Parent  5af80d29c4411d2bb58cb4356851f0543376dcec
>> tests/run-tests: avoid C:/ in arguments
> 
> Agreed, this seems to be the most elegant solution. It seems to be a 
> step in the right direction and removes the regression with the test 
> setup described on the wiki and used by the buildbot. Pushed to crew, 
> thanks.

Thanks for reviewing and pushing. Test coverage on Windows is rising!

> This cleanup means that we should avoid using $TESTTMP and $TESTDIR in 
> places where sh can see them ... but that is fortunately not much of a 
> problem.

Yes. Let's see how far we get with this.

> We still have the 'xC:/x' problem in the places where we use `pwd` ... 
> because of the alias. That could perhaps be avoided somehow, but for now 
> I have pushed some workarounds.

Indeed. We still have the problem that pwd is aliased to pwd -W which
returns the path in the MSYS-deadly C:/ form:

  $ pwd -W
  C:/Users/adi/hgrepos/hg-main

It's on TODO.


More information about the Mercurial-devel mailing list