[PATCH V2] test-init: enable for Windows

Mads Kiilerich mads at kiilerich.com
Tue Jun 12 05:49:03 CDT 2012


On 12/06/12 09:00, Adrian Buehlmann wrote:
> Soo... Perhaps we also want (in order not to give bad examples):
>
> # HG changeset patch
> # User Adrian Buehlmann <adrian at cadifra.com>
> # Date 1339483993 -7200
> # Node ID 7aa487d87cdd9aeaf699d02e012b77299dc0df6d
> # Parent  b112e265b78a614dac15d5be92d39926d5e653da
> test-init.t: remove unneeded explicit exit code checking
>
> check-code said somewhere else:
>
> +   >   $ test -d " " -a -d " /.hg" && echo "ok" || echo "failed"
> +   explicit exit code checks unnecessary
> +  FAILURE IS NOT AN OPTION!!!
>
> diff --git a/tests/test-init.t b/tests/test-init.t
> --- a/tests/test-init.t
> +++ b/tests/test-init.t
> @@ -123,19 +123,10 @@
>   check names for repositories (clashes with URL schemes, special chars)
>   
>     $ for i in bundle file hg http https old-http ssh static-http "with space"; do
> -  >   printf "hg init \"$i\"... "
>     >   hg init "$i"
> -  >   test -d "$i" -a -d "$i/.hg" && echo "ok" || echo "failed"
> +  >   test -d "$i"
> +  >   test -d "$i/.hg"
>     > done

No; the exit code testing is done by the salt run-tests adds at the end 
of commands. It doesn't work within sh constructs.

/Mads


More information about the Mercurial-devel mailing list