[PATCH 1 of 2 RFC] tests/hghave: extract hghave.py

[Mads Kiilerich]

On 12/06/12 14:58, Adrian Buehlmann wrote:
> On 2012-06-12 13:39, Mads Kiilerich wrote:
>> On 12/06/12 13:17, Adrian Buehlmann wrote:
>>> # HG changeset patch
>>> # User Adrian Buehlmann <adrian at cadifra.com>
>>> # Date 1339495270 -7200
>>> # Node ID a52c543f0523f83d0c313b934646e9692fae254a
>>> # Parent  b112e265b78a614dac15d5be92d39926d5e653da
>>> tests/hghave: extract hghave.py
>>>
>>> hghave is degraded to a bare script, moving the functions to hghave.py
>>> so they can be shared later on.
>> I would start by introducing a '#require' syntax that could replace
>> hghave completely.
>>
>> Before that I would convert as many of the remaining hghave's as
>> possible to #if.
> Does that mean that if my patches would be taken, they are not an
> improvement or that the would morph the code into a direction which is
> not what's wanted?

It was just a comment - as you requested. It was not a conclusion. I 
also didn't express any opinion - I just gave a quick full disclosure on 
the slightly different priorities I would have made and the slightly 
different path I would have taken. FYI, while you are cooking.

/Mads