[PATCH V4] test-walk: enable for Windows

[Adrian Buehlmann]

On 2012-06-12 12:19, Mads Kiilerich wrote:
> Moving 'glob:glob' might however lead to reductio ad absurdum. It is 
> possible that 'glob:glob' doesn't test anything relevant that isn't 
> tested elsewhere. It just don't think the case should be removed 
> silently without reasonable arguments.

The absurdity is indeed not insignifcant. At least it appears so on my end.

The net result is that test-walk.t is still not tested on Windows. We
can aim for perfection for quite some more time if we want. But if the
cost is not having this test enabled on Windows, then I think it's not
worth that cost.

FWIW, I tried to remove the glob:glob case in one of my early tries of
this patch because it is simply an illegal filename on Windows (colon is
a reserved character).

This part of the (continued) discussions appears a bit odd to me, given
how much dedication people are obviously investing into having warnings
about non-portable filenames elsewhere.

But obviously, your and my mileage seem to vary.

And yes, off the top of my head I can't think of a reason why a
glob:glob file by itself should be a relevant testcase. But I indeed
haven't digged deep enough into the functions that are tested here.