[PATCH stable] findrepo(), walkrepos(): skip repositories not readable with current privileges; skip empty '.hg' directories, e.g. unmounted mountpoint

Martin Geisler martin at geisler.net
Thu Jun 14 07:06:04 CDT 2012


Adrian Buehlmann <adrian at cadifra.com> writes:

> On 2012-06-14 01:31, Martin Geisler wrote:
>> (Minor detail: I read foo() as the result of calling foo, so if I want
>> to talk about the function foo, I leave out the parenthesis.)
>
> I just noticed that I seem to have that done differently myself.
>
> Patrick seems to disagree with you as well? (e.g. 058e14da7044).
>
> And the python docs use func() all over the place:
>
>   http://docs.python.org/library/functions.html

Yeah, it was just a personal opinion and I'm pretty sure I'm in the
minority here. Lots and lots of programmers write foo() when talking
about the foo function -- even if it can never be called without
arguments. That's what makes it look silly to me.

It's perfectly fine to include the () in the commit message.

-- 
Martin Geisler

aragost Trifork
Commercial Mercurial support
http://aragost.com/mercurial/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 835 bytes
Desc: not available
URL: <http://selenic.com/pipermail/mercurial-devel/attachments/20120614/0ceeb6a8/attachment.pgp>


More information about the Mercurial-devel mailing list