[PATCH 4 of 6 v6] discovery: convert legacy part of checkheads to revs from nodes

Bryan O'Sullivan bos at serpentine.com
Thu Jun 14 18:20:09 CDT 2012


These hunks concern me, but I don't know the discovery code well enough to
know if my concern is valid.


> -        if len(newheads) > 1:
> -            for latest in reversed(outgoing.missing):
>

This reverses the missing node list.

+        if len(newheadrevs) > 1:
>
+            for latest in sorted(missingrevs, reverse=True):
>

This sorts the missing rev list in inverse rev order, which seems unlikely
to be the same operation.

What I don't know is whether that matters.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://selenic.com/pipermail/mercurial-devel/attachments/20120614/1d20b316/attachment.html>


More information about the Mercurial-devel mailing list