[PATCH 1 of 8 RFC] vfs: replace invocation of file APIs of os module by ones via vfs

[Adrian Buehlmann]

On 2012-06-18 21:26, Matt Mackall wrote:
> On Sun, 2012-06-17 at 09:49 +0200, Adrian Buehlmann wrote:
>> On 2012-06-17 08:25, Matt Mackall wrote:
>>> On Sat, 2012-06-16 at 11:07 +0200, Adrian Buehlmann wrote:
>>>> Have you guys put some thought into how to deal with repo root paths
>>>> that contain "wide" characters already?
>>>
>>> No, and in fact I'd rather not think about that now. This topic is
>>> already muddy/complex enough, so I've tried to carve off a solvable
>>> piece to tackle.
>>
>> I think solving this one first might be better than ignoring it now and
>> having to deal with it later.
>>
>> If we ignore that now, we are chosing solutions based on that "ignoring".
> 
> On the other hand, if people insist on expanding the problem scope to
> include all the related problems, the resulting problem will be too
> large to ever tackle.
> 
> Which is why I've very explicitly tried to focus on the "checking in and
> out UTF-8 names" issue. It's functionally the most important Unicode
> issue BY FAR, we have a plan, and we can move forward.
> 

Ok. So let's see patches.

>> I think solving this one first would actually be easier now.
> 
> Ok, what's your theory?
> 
> I spent most of the weekend on further investigations of Windows Unicode
> support and my conclusion is:
> 
> - the least painful way to handle this is to encapsulate the root path
> with encoding.localstr() and then make sure all path-joining and
> splitting is done with a localstr()-aware method
> - that will be easier _after_ VFS objects are in place
> - there's no reason to think lacking this feature stops people from
> doing useful work
>