[PATCH 7 of 7] revset: replace remaining uses of range with xrange

Matt Mackall mpm at selenic.com
Mon Jun 18 17:43:50 CDT 2012


On Mon, 2012-06-04 at 15:25 -0700, Bryan O'Sullivan wrote:
> # HG changeset patch
> # User Bryan O'Sullivan <bryano at fb.com>
> # Date 1338848634 25200
> # Node ID d4055f34012ad1013ad830f939ee7d7d9c7abc1c
> # Parent  f6029089455346072a71c32952853252ff3d3ee7
> revset: replace remaining uses of range with xrange

That looks like a gimme? Send it first?

> diff --git a/mercurial/revset.py b/mercurial/revset.py
> --- a/mercurial/revset.py
> +++ b/mercurial/revset.py
> @@ -301,9 +301,9 @@ def rangeset(repo, subset, x, y):
>      m, n = m[0], n[-1]
>  
>      if m < n:
> -        r = range(m, n + 1)
> +        r = xrange(m, n + 1)
>      else:
> -        r = range(m, n - 1, -1)
> +        r = xrange(m, n - 1, -1)
>      return filterrevs(r, subset, contig=True)
>  
>  def dagrange(repo, subset, x, y):
> @@ -389,7 +389,7 @@ def ancestorspec(repo, subset, x, n):
>      ps = set()
>      cl = repo.changelog
>      for r in getset(repo, subset, x):
> -        for i in range(n):
> +        for i in xrange(n):
>              r = cl.parentrevs(r)[0]
>          ps.add(r)
>      return [r for r in subset if r in ps]


-- 
Mathematics is the supreme nostalgia of our time.




More information about the Mercurial-devel mailing list