test-subrepo-git.t on windows

[Benjamin Pollack]

On 6/19/2012 3:41 PM, Eduard-Cristian Stefan wrote:
> On 2012-06-19 18:02, Benjamin Pollack wrote:
>> I already submitted a patch last week that fixes this a week ago 
>> (http://www.selenic.com/pipermail/mercurial-devel/2012-June/041457.html). 
>> Basically, the most common Git on Windows (MSYS) only installs 
>> git.cmd in the path, and subprocess.Popen, for whatever reason, 
>> doesn't find that kind of batch file.  My patch tries plain "git", 
>> then falls back to an explicit git.cmd on Windows on failure.  It 
>> works fine and passes the test suite, both with and without Git 
>> installed.
>
> The patch works just fine, but test-subrepo-git.t fails on my PC.
>
> On default branch rev 132ea1736751 + your patches I get these errors:
>
> --- d:\hg\tests\test-subrepo-git.t
> +++ d:\hg\tests\test-subrepo-git.t.err
> @@ -25,6 +25,8 @@
>    $ git init -q
>    $ echo g > g
>    $ git add g
> +  warning: LF will be replaced by CRLF in g.
> +  The file will have its original line endings in your working directory.

You have Git's core.autocrlf setting on "true", which is the default on 
Windows.  Set it to "input" to match other platforms, and these should 
go away.

--Benjamin