[PATCH] test-subrepo-git.t: adapt for Windows

Adrian Buehlmann adrian at cadifra.com
Tue Jun 19 16:22:48 CDT 2012


On 2012-06-19 22:33, alexandrul.ct at gmail.com wrote:
> # HG changeset patch
> # User Eduard-Cristian Stefan <alexandrul.ct at gmail.com>
> # Date 1340137939 -10800
> # Node ID a20a2088c90c3e3781d2c6415a23ff0b2c6f8203
> # Parent  ee18cedec2c29a9aa2830c929225f83a6931f473
> test-subrepo-git.t: adapt for Windows

[..]

> @@ -509,8 +511,14 @@
>  
>  Test forgetting files, not implemented in git subrepo, used to
>  traceback
> -  $ hg forget 'notafile*'
> -  notafile*: No such file or directory
> +#if unix-permissions

Why unix-permissions? I think you possibly might want #if no-windows (?)

> +  $ hg forget 'notafile'
> +  notafile: No such file or directory
>    [1]
> +#elsif

That's basically a syntax error here (only #else is implemented), but
run-tests.py will parse it as a comment, it will thus continue to skip
the following commands (and output lines) if run on Windows, until the
#endif is reached. In other words: your #elsif is ignored.

(So I do wonder a bit how you have tested this patch...:-)

> +  $ hg forget 'notafile'
> +  notafile: The system cannot find the file specified

That sounds like a Windows error text, which perhaps should be (glob)'ed
away for those people using a non-English Windows (e.g. German) [see a
recent comment by Mads to one of my patches]

> +  [1]
> +#endif
>  
>    $ cd ..



More information about the Mercurial-devel mailing list