[PATCH] test-subrepo-git.t: adapt for Windows

Eduard-Cristian Stefan alexandrul.ct at gmail.com
Tue Jun 19 17:41:09 CDT 2012


On 2012-06-20 00:22, Adrian Buehlmann wrote:
>> @@ -509,8 +511,14 @@
>>
>>   Test forgetting files, not implemented in git subrepo, used to
>>   traceback
>> -  $ hg forget 'notafile*'
>> -  notafile*: No such file or directory
>> +#if unix-permissions
>
> Why unix-permissions? I think you possibly might want #if no-windows (?)

bebe376b938f. Also based on usage:

- "#if unix-permissions" it's used in 7 tests
- "#if no-windows" appears only in test-add.t
- "#if windows" appears only in test-hook.t

>> +  $ hg forget 'notafile'
>> +  notafile: No such file or directory
>>     [1]
>> +#elsif
>
> That's basically a syntax error here (only #else is implemented), but
> run-tests.py will parse it as a comment, it will thus continue to skip
> the following commands (and output lines) if run on Windows, until the
> #endif is reached. In other words: your #elsif is ignored.

My mistake.

> (So I do wonder a bit how you have tested this patch...:-)

Only on Windows.

>> +  $ hg forget 'notafile'
>> +  notafile: The system cannot find the file specified
>
> That sounds like a Windows error text, which perhaps should be (glob)'ed
> away for those people using a non-English Windows (e.g. German) [see a
> recent comment by Mads to one of my patches]

Something like "notafile: * (glob)" ?


More information about the Mercurial-devel mailing list