[PATCH] test-push-http: adapt for Windows

Adrian Buehlmann adrian at cadifra.com
Thu Jun 21 01:55:42 CDT 2012


On 2012-06-21 03:59, Mads Kiilerich wrote:
> Adrian Buehlmann wrote, On 06/19/2012 07:10 PM:
>> # HG changeset patch
>> # User Adrian Buehlmann <adrian at cadifra.com>
>> # Date 1340125721 -7200
>> # Node ID aa0f472fd3287f11f3ea8eb1aafa2d91f4512ac1
>> # Parent  ba43e874b4ee2865e96582b756113b03ef43ec7b
>> test-push-http: adapt for Windows
> 
> Instead of
> [PATCH] test-hgweb-descend-empties: adapt for Windows
> [PATCH] test-hgwebdir: adapt for Windows
> [PATCH] test-hgweb-commands: adapt for Windows
> [PATCH] test-hgweb-raw: adapt for Windows
> [PATCH] test-hgweb-filelog: adapt for Windows
> [PATCH] test-hgweb-removed: adapt for Windows
> [PATCH] test-hgweb-empty: adapt for Windows
> [PATCH] test-hgweb: adapt for windows
> [PATCH] test-push-http: adapt for Windows
> I pushed changes that should have fixed the problems across all tests.
> 
> For get-with-headers.py I took the different approach of leaving out the 
> leading slash instead of doubling it.
> 
> If anything has been lost then please resend - preferably reducing 
> trivial changes in several files to one patch or by using threaded 
> mailbombs.

Thanks.

We've had similar discussions in 2010 (during the big unified tests
move) about whether you guys want such things in one large patch or
isolated patches. Matt's stance back then was that he was ok with me
sending things in isolated patches, as I did here.

However, I will do as you say.

But I think I've largely finished sending such patches anyway here. I
think the test enabling/adapting-for-Windows-move is nearing completion.

I'll push my stuff to https://bitbucket.org/abuehl/mercurial-testing (a
fork), you can take whatever you like from there. Almost all "hghave
serve" tests are now working there as well. The process killing stuff
still works fine so far (except for the ugly pop up windows, which are
annoying but don't do harm to the running tests themselves).

I think we've now achieved a big step forward regarding test coverage on
Windows.




More information about the Mercurial-devel mailing list