[PATCH 3 of 5] largefiles: remove a standin check that could never be true

Na'Tosha Bard natosha at unity3d.com
Thu Jun 21 07:25:18 CDT 2012


2012/6/20 Matt Harbison <matt_harbison at yahoo.com>

> # HG changeset patch
> # User Matt Harbison <matt_harbison at yahoo.com>
> # Date 1340073921 14400
> # Node ID f4bc770430b15cdabf07676f5ae1d6611696aba2
> # Parent  0588cf50d6e8b4c06d4263418ef3b1dcc87a2bf8
> largefiles: remove a standin check that could never be true
>
> diff --git a/hgext/largefiles/overrides.py b/hgext/largefiles/overrides.py
> --- a/hgext/largefiles/overrides.py
> +++ b/hgext/largefiles/overrides.py
> @@ -818,8 +818,6 @@
>     lfcommands.cachelfiles(ui, repo._repo, ctx.node())
>
>     def write(name, mode, islink, getdata):
> -        if lfutil.isstandin(name):
> -            return
>         data = getdata()
>
>         archiver.addfile(prefix + repo._path + '/' + name, mode, islink,
> data)
>

Without a larger context from the diff, it is hard to tell -- why could
this never be true?  Simply because there is no codepath that calls write()
with a standin?

Cheers,
Na'Tosha

-- 
*Na'Tosha Bard*
Software Developer | Unity Technologies - Copenhagen

*E-Mail:* natosha at unity3d.com
*Skype:* natosha.bard
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://selenic.com/pipermail/mercurial-devel/attachments/20120621/eb89e929/attachment.html>


More information about the Mercurial-devel mailing list