[PATCH 1 of 1] test-subrepo-svn.t: adapt for Windows

[Mads Kiilerich]

On 21/06/12 12:05, Eduard-Cristian Stefan wrote:
> On Thu, Jun 21, 2012 at 11:33 AM, Mads Kiilerich <mads at kiilerich.com> wrote:
>> It worked fine with 1.7 on linux ... but fails with this patch. The 
>> reason must be something else. 
> I had to update the grep expression to catch the svn 1.7.5 extra line
> on windows.

Please make sure the patch description in reasonable details summarize 
the changes and explain why they are done. That makes it much easier to 
review and understand when someone in the future goes back in history 
and try to understand the change.

It is however not so relevant to list in the _commit_ description what 
changed between the two last drafts.

The path globs and handling of platform specific error codes might be so 
obvious that they don't need mentioning. The change of the name of the 
'forget' file should however be mentioned and explained briefly.

It seems very strange that the python expression for escapedwd is needed 
on some platforms but not on windows. I would expect the commit 
description to explain that. (And escapedwd should probably just be 
created 'correctly' instead of being used in different ways.)

We do for some reason use 'egrep' instead of 'grep -E' in the rest of 
the tests. -E is probably fine on all platforms too, but I would just 
use a simple
grep -v 's[/\]externals[/\]other'

/Mads