[PATCH] test-commandserver: use shell=True on Popen call

Adrian Buehlmann adrian at cadifra.com
Thu Jun 21 15:20:14 CDT 2012


On 2012-06-21 13:55, Adrian Buehlmann wrote:
> # HG changeset patch
> # User Adrian Buehlmann <adrian at cadifra.com>
> # Date 1340237612 -7200
> # Node ID f8b04734fc337fdfc53cfed414b88c3e68e9c566
> # Parent  3e2d8120528b75389cda669f47a78c53be917839
> test-commandserver: use shell=True on Popen call
> 
> This allows to run the test in MSYS shell on Windows without a exemaker hg.exe,
> but a hg.cmd containing (see also contrib/win32/hg.bat):
> 
>   @echo off
>   python "%~dp0hg" %*
> 
> diff --git a/tests/test-commandserver.py b/tests/test-commandserver.py
> --- a/tests/test-commandserver.py
> +++ b/tests/test-commandserver.py
> @@ -5,7 +5,7 @@
>      if path:
>          cmdline += ['-R', path]
>  
> -    server = subprocess.Popen(cmdline, stdin=subprocess.PIPE,
> +    server = subprocess.Popen(cmdline, shell=True, stdin=subprocess.PIPE,
>                                stdout=subprocess.PIPE)
>  
>      return server

Patch voided. Not to be pushed.

See http://selenic.com/pipermail/mercurial-devel/2012-June/041876.html


More information about the Mercurial-devel mailing list