[PATCH 2 of 2] scmutil: change canonpath to use util.samefile (issue2167)

[Mads Kiilerich]

Adrian Buehlmann wrote, On 06/20/2012 11:17 PM:
> On 2012-06-20 23:08, Mads Kiilerich wrote:
>> Matt Mackall wrote, On 06/20/2012 09:56 PM:
>>> On Thu, 2012-06-14 at 11:44 +0200, Adrian Buehlmann wrote:
>>>> # HG changeset patch
>>>> # User Adrian Buehlmann <adrian at cadifra.com>
>>>> # Date 1339667028 -7200
>>>> # Node ID d031d0bd4ffe489f7c1afe3d10f281a308afeabf
>>>> # Parent  cbddd5db525031ee953f165cb902048d6a3f1292
>>>> scmutil: change canonpath to use util.samefile (issue2167)
>>> These are queued for default, thanks.
>>>
>> Can 4d95878712ad then be backed out again - or what is missing?
> I don't think a backout of 4d95878712ad is needed. There's nothing wrong
> with 4d95878712ad.

The commit message did for some reason make me think it was a short-term 
workaround.

Issue 3490 is marked IN_PROGRESS. That made me think that there was more 
to it.

> But you can surely try your luck and go back to forcing the all
> lowercase tempfile path on the suite.
>
> I'd just recommend removing that workaround with a proper patch,
> explaining in the change message what you are doing and why.

I don't think I have ever seen the problem it should fix myself, but I 
trusted you that it was a real problem. Now I realize that the reason 
you had the problem probably was that you don't follow the wiki and set 
TMPDIR to c:/tmp but use your own undocumented method for running the tests.

I doubt I can make a fair and correct backout description, and only you 
can tell what good the patch really did or still do ... or why it should 
be permanent instead of temporary as it apparently was intended.

/Mads