[PATCH 2 of 2] scmutil: change canonpath to use util.samefile (issue2167)

Mads Kiilerich mads at kiilerich.com
Thu Jun 21 19:27:27 CDT 2012


Adrian Buehlmann wrote, On 06/21/2012 11:42 PM:
> And yeah, I don't set TMPDIR when running the suite. Do we have to rely
> on setting TMPDIR? Or can we trust Windows on knowing where the correct
> temp directory is, as it's specified?

In some cases the 8.3 names will show up if long filenames are used, and 
TEMP will on some systems by default be a folder with long names.

> I suggest you leave that change in. If you need more explanation, then
> ask. What's not clear about it any more?

Why do you no longer consider it a temporary workaround? What good will 
it do now when you have fixed the real problem?

/Mads


More information about the Mercurial-devel mailing list