[PATCH 2 of 2] scmutil: change canonpath to use util.samefile (issue2167)

[Adrian Buehlmann]

On 2012-06-22 02:27, Mads Kiilerich wrote:
> Adrian Buehlmann wrote, On 06/21/2012 11:42 PM:
>> And yeah, I don't set TMPDIR when running the suite. Do we have to rely
>> on setting TMPDIR? Or can we trust Windows on knowing where the correct
>> temp directory is, as it's specified?
> 
> In some cases the 8.3 names will show up if long filenames are used, and 
> TEMP will on some systems by default be a folder with long names.
> 
>> I suggest you leave that change in. If you need more explanation, then
>> ask. What's not clear about it any more?
> 
> Why do you no longer consider it a temporary workaround? What good will 
> it do now when you have fixed the real problem?

As I've said, the fix is not strictly needed any more, but Python's
tempfile.mkdtemp() still returns all lowercase paths without my change,
which is quite unusual and may bite us later on as a surprise.

So I personally see no need to remove my "fix".

Do you see any need to remove it? What is the benefit in removing it? If
there is one, then remove it.

I don't understand why you are so insisting here. But for the sake of
peace, please go ahead on back it out.