[PATCH 0 of 1 ] test-ssh.t: adapt for Windows

[Adrian Buehlmann]

On 2012-06-24 00:25, Mads Kiilerich wrote:
> alexandrul.ct at gmail.com wrote, On 06/23/2012 07:20 PM:
>> On my PC this is the result without this patch:
>>
>> --- d:\hg\tests\test-ssh.t
>> +++ d:\hg\tests\test-ssh.t.err
>> @@ -348,13 +348,13 @@
>>
>>     $ cat dummylog
>>     Got arguments 1:user at dummy 2:hg -R nonexistent serve --stdio
>> -  Got arguments 1:user at dummy 2:hg -R /$TESTTMP/nonexistent serve --stdio
>> +  Got arguments 1:user at dummy 2:hg -R '/$TESTTMP/nonexistent' serve --stdio
>>     Got arguments 1:user at dummy 2:hg -R remote serve --stdio
>>     Got arguments 1:user at dummy 2:hg -R remote serve --stdio
>>     Got arguments 1:user at dummy 2:hg -R remote serve --stdio
>>     Got arguments 1:user at dummy 2:hg -R remote serve --stdio
>>     Got arguments 1:user at dummy 2:hg -R local serve --stdio
>> -  Got arguments 1:user at dummy 2:hg -R $TESTTMP/local serve --stdio
>> +  Got arguments 1:user at dummy 2:hg -R '$TESTTMP/local' serve --stdio
>>     Got arguments 1:user at dummy 2:hg -R remote serve --stdio
>>     changegroup-in-remote hook: HG_NODE=a28a9d1a809cab7d4e2fde4bee738a9ede948b60 HG_SOURCE=serve HG_URL=remote:ssh:127.0.0.1
>>     Got arguments 1:user at dummy 2:hg -R remote serve --stdio
> 
> As you (indirectly) can see on 
> http://hgbuildbot.kublai.com/builders/Windows%202008%20R2%20hg%20tests 
> it passes on other machines.
> 
> I would like to understand why it fails for you before we commit a 
> workaround. A failing test might indicate that there is a bug that 
> should be fixed - making the test accept the wrong output is not the way 
> to solve that.

I agree with Mads.

> Please try to research the issue you and and figure out what it is that 
> is failing and why it is failing. The explanation should be a part of 
> the commit message.
> 
> I guess it could be related to running the tests in an undocumented way 
> and having a strange tmp path.

It also passes here with ec5ef276077f using

  $ PATH="/mingw/bin:/bin:/c/python" ./run-tests.py --local test-ssh.t
  .
  # Ran 1 tests, 0 skipped, 0 failed.

and my hg.exe [1] in the repo root (64-bit, Python 2.7). The hg file
renamed to hg.py.

[1] https://bitbucket.org/abuehl/hgexe