[PATCH] test-subrepo-svn.t: partially adapt for Windows

Mads Kiilerich mads at kiilerich.com
Tue Jun 26 05:21:37 CDT 2012


On 26/06/12 12:07, Eduard-Cristian Stefan wrote:
> On 2012-06-26 04:40, Mads Kiilerich wrote:
>> I have pushed a cleanup of these subversion urls to crew. That makes 
>> this test pass for me. If nothing else it can be used as a baseline 
>> for future work.
>
> Thank you.
>
> I still get this error with SVN 1.6.17:
>
>     --- d:\hg\tests\test-subrepo-svn.t
>     +++ d:\hg\tests\test-subrepo-svn.t.err
>     @@ -485,7 +485,7 @@
>
>        $ hg ci --subrepos -m cleanup | grep -v Updating
>        committing subrepository obstruct
>     -  Sending        obstruct/other (glob)
>     +  Sending 
> Administrator\AppData\Local\Temp\hgtests.kkslmj\test-subrepo-svn.t\rebaserepo\obstruct\other
>        Transmitting file data .
>        Committed revision 7.
>        At revision 7.
>
>     ERROR: d:\hg\tests\test-subrepo-svn.t output changed
>     !
>     Failed test-subrepo-svn.t: output changed
>     # Ran 1 tests, 0 skipped, 1 failed.
>
> Is there a windows user for which the test passes with SVN 1.6.17?
> Or should I simply use SVN 1.7.5 in the future?

Right - you had a workaround for that in your patch. I left it out 
because I didn't know what issue it solved and why simply ignoring the 
extra output was the right solution. Now we know what issue it was 
working around - but not why there is a need for the workaround and if 
there is a real problem hiding here.

What temp directory are you using? Could it by any chance be 
x:\Administrator\... on a different drive? Or why could subversion 
possibly emit this long almost-absolute path?

The test passes with 1.6 and 1.7 on linux, and I have seen it pass with 
one I-don't-know-which version on windows.

Some progress on the other subversion tests will perhaps reveal if this 
is a general problem or what is going on.

/Mads


More information about the Mercurial-devel mailing list