[PATCH 2 of 2 STABLE] amend: disable hooks when creating intermediate commit (issue3501)

Idan Kamara idankk86 at gmail.com
Thu Jun 28 12:37:42 CDT 2012


On Thu, Jun 28, 2012 at 7:12 PM, Pierre-Yves David <
pierre-yves.david at logilab.fr> wrote:
>
> On Wed, Jun 27, 2012 at 11:23:04AM +0300, Idan Kamara wrote:
> > On Wed, Jun 27, 2012 at 1:08 AM, Pierre-Yves David <
> > pierre-yves.david at ens-lyon.org> wrote:
> > >
> > >
> > > On 23 juin 2012, at 18:58, Idan Kamara wrote:
> > >
> > > > # HG changeset patch
> > > > # User Idan Kamara <idankk86 at gmail.com>
> > > > # Date 1340470649 -10800
> > > > # Branch stable
> > > > # Node ID e3dfdc0b9fe1878a8c98b92ea5eb4d264be589d5
> > > > # Parent  26afc4b68fb967ade439d529ac6296faa7cb19c7
> > > > amend: disable hooks when creating intermediate commit (issue3501)
> > >
> > > meh, I would rather see the extra commit disappear than hackly disable
> > hook during this unneeded commit.
> >
> > This isn't the first time I hear you complain about the implementation,
> > so
> > really at this point actions speak louder than words.
>
> I'm trying the Matt approach here: tagging simple and hackish approach as
> bad
> until the complexe but correct version I want get written :-)

I don't think this is 'hacky', so please explain how you'd fix this bug
properly (don't say "rewrite --amend" unless we can expect a patch
from you soon).

Anyway, I'm already using this in my own stash implementation that
creates commits internally so there might be other clients for this in
the future.

>
> I probably need some more training though.
>
>
> --
> Pierre-Yves David
>
> http://www.logilab.fr/
>
>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.10 (GNU/Linux)
>
> iEYEARECAAYFAk/sgnsACgkQElczi7p/bN89BwCfQrAye2xdZO2gJjg7oWMWdCdC
> HN8An18HpmXFbJOxQfiCFNEYDa7KgFYt
> =D55R
> -----END PGP SIGNATURE-----
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://selenic.com/pipermail/mercurial-devel/attachments/20120628/d7f8309c/attachment.html>


More information about the Mercurial-devel mailing list