[PATCH] run-tests: alias hg to hg.exe for Windows

[Matt Mackall]

On Thu, 2012-06-28 at 20:35 +0200, Adrian Buehlmann wrote:
> On 2012-06-28 20:09, Matt Mackall wrote:
> > On Wed, 2012-06-27 at 03:17 +0200, Adrian Buehlmann wrote:
> >> # HG changeset patch
> >> # User Adrian Buehlmann <adrian at cadifra.com>
> >> # Date 1340759693 -7200
> >> # Node ID 52b63762a69feaf2e2a959a41a4d6947d0c922b0
> >> # Parent  ab4644c3064fd12738b18d6f65c6acd5799d57b3
> >> run-tests: alias hg to hg.exe for Windows
> > 
> > I guess this is fine. But let's queue this up after we get hg.exe in the
> > tree for the sake of correctness. We have lots of tests that run
> > correctly without, this would make us entirely dependent.
> 
> There are only a handful tests that depend on hg.exe today (e.g.
> test-commandserver.py), which was the whole point of me trying to get
> away without the (then exemaker) hg.exe in the first place.

Right, this is exactly my point. The test suite mostly works today
without hg.exe (as you've observed). 

Given that, the correct _order_ to do things is:

a) include hg.exe
b) alias hg to hg.exe in the test suite

If you do it the other way, much of the test suite is needlessly broken
between steps. There's nothing to be confused about here, this is just a
trivial and pedantic application of our long-standing process rule:
don't break things between patches.

> With regards to this patch here, like I already said, we can put the
> alias into
> 
>   C:\MinGW\msys\1.0\etc\profile

I'm actually not sure adding it to the profile is preferable. Both are
hacks, but one is a detail hidden by test suite. If we need a hack (and
it seems we do), I'd tend to prefer the latter.

-- 
Mathematics is the supreme nostalgia of our time.