[PATCH] fix push of moved bookmark on new branch head

Sune Foldager cryo at cyanite.org
Sat Jun 30 15:34:02 CDT 2012


On 2012-06-26 16:31, Matt Mackall wrote:
>On Sun, 2012-06-24 at 20:07 +0200, Sune Foldager wrote:
>> # HG changeset patch
>> # User Sune Foldager <cryo at cyanite.org>
>> # Date 1340561203 -7200
>> # Node ID da2ad8d2145be13166e289b8e91de324699e0296
>> # Parent  ec5ef276077f9141f2ee4205ebcec9b48c6a0da0
>> fix push of moved bookmark on new branch head
>
>Non-canonical subject line.
>
>> The code only worked for local remotes, and wasn't touched by the test suite.
>
>Please try the form "when I try to do X, I get result Y, but the result
>should be Z". This is better than "X does not work" which assumes a
>common understanding of what it means for X to work and leaves the
>reader to intuit what Y and Z might have been.

Good point.

>I for one have no idea what Y and Z are here, and I'm a little hazy on X
>to be honest.

Since this was pushed, it's too late for the cset desc, but let me explain
it here:

X: push a changeset which moves a bookmark forward, and at the same time
creates a new named branch head.

Y: hg crashes with 'is not subscriptable' (since the code did repo[...])

Z: hg shouldn't crash, and should accept the push since we're moving a
bookmark. This was the intention of the original patch.

-Sune


More information about the Mercurial-devel mailing list