[PATCH] posix: add configuration option to ignore execution mode changes (issue3301)

Angel Ezquerra angel.ezquerra at gmail.com
Fri Mar 2 09:05:38 CST 2012


On Mar 2, 2012 2:44 PM, "A. S. Budden" <abudden at gmail.com> wrote:
>
> On 2 March 2012 12:42, Angel Ezquerra Moreu <angel.ezquerra at gmail.com>
wrote:
> > On Fri, Mar 2, 2012 at 1:38 PM, A. S. Budden <abudden at gmail.com> wrote:
> >> On 2 March 2012 12:25, Angel Ezquerra Moreu <angel.ezquerra at gmail.com>
wrote:
> >>> On Fri, Mar 2, 2012 at 1:20 PM, A. S. Budden <abudden at gmail.com>
wrote:
> >>>> # HG changeset patch
> >>>> # User A. S. Budden <abudden at gmail.com>
> >>>> # Date 1330690534 0
> >>>> # Node ID 105fae68f78292cebd41e118bc68b24c171fa553
> >>>> # Parent  85db991780b7b86913c3e29a5fe7ef25ab5ee93c
> >>>> posix: add configuration option to ignore execution mode changes
(issue3301)
> >>>>
> >>>> Using a posix version of Mercurial on a filesystem (such as FAT)
> >>>> without support for the executable bit can result in Mercurial
> >>>> erroneously reporting/committing executable bit changes.
> >>>>
> >>>> This patch adds an 'ignoreexec' option to the 'ui' field in hgrc
> >>>> to allow a user to make the posix version act like the Windows
> >>>> version and ignore execution mode changes.  This is roughly
> >>>> equivalent to Git's core.filemode option.
> >>>
> >>> I find the setting name "ui.ignoreexec" a bit unclear, particularly
> >>> the fact that it stems directly from the ui section. Also it is not
> >>> clear what sort of "exec" you are ignoring.
> >>
> >> Fair enough.
> >>
> >>> Instead, maybe it could be called "ui.commit.ignoreexecbit"?
> >>
> >> That's certainly easy to change... I'm not sure about the 'ui.commit'
> >> bit though: it affects 'hg st' as well as 'hg commit': would it be
> >> better as 'ui.ignoreexecbit'?
> >>
> >> Al
> >
> > OK, I did not realize that.
> >
> > "ui.ignoreexecbit" would definitely be better, but I still find the
> > name slightly generic. Does this really belong in the "ui" section.
>
> I don't know: can you suggest a better section?  I really don't mind
> where it goes.
>
> Al

I don't really know. Looking at the existing sections on the hgrc wiki page
I don't really see an obvious section...

To me it feels as a sort of "encode" option, but I don't think it's
possible to put non patterns in that section. It is also related to the
diff section, but it doesn't really belong there either...

Maybe someone else has a better idea? Otherwise I guess ui would be ok.

Angel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://selenic.com/pipermail/mercurial-devel/attachments/20120302/35b2bdaa/attachment.html>


More information about the Mercurial-devel mailing list