[issue3317] journal.bookmarks transaction recovery error on multi-committer repos

[Michael Bacarella]

New submission from Michael Bacarella <mbac at panix.com>:

A user can render other users unable to push to the repo if the repo uses
bookmarks by aborting the transaction.  The aborted transaction leaves a
journal.bookmarks file that cannot be recovered by others hg users.

The error manifests as 'Operation not permitted' against the file
'journal.bookmarks'.

This issue only affects bookmarks because, unlike the other journal.* files,
a different code path is exercised to create the journal.bookmarks file, one
which calls chmod after copying the data.  On UNIX, only the file's owner
can change the mode, which will fail if a different user has aborted a
transaction in the repo.

Proposed fix is to copy the journal.bookmarks file the same way
journal.dirstate is copied.

----------
messages: 19358
nosy: mbacarella
priority: bug
status: unread
title: journal.bookmarks transaction recovery error on multi-committer repos
topic: 2.0, bookmarks

____________________________________________________
Mercurial issue tracker <bugs at mercurial.selenic.com>
<http://mercurial.selenic.com/bts/issue3317>
____________________________________________________