[PATCH] patchbomb: add --text flag to send patches both as inline text and as attachments

Greg Ward greg at gerg.ca
Wed Mar 21 08:38:40 CDT 2012


On 21 March 2012, Angel Ezquerra Moreu said:
> You are right. I did not like "--text" too much but I could not think
> of anything better. I like "in-body" much more!

Actually, I prefer --body. Short and sweet. Prepositions just get in
the way. ;-)

> I believe that it is currently preferred not to use "-" on flag names.
> However the email command already uses them on several of its flag
> names (e.g. reply-to and in-reply-to). Should the new option be called
> "inbody" instead?

I don't recall seeing documentation or an official pronouncement
anywhere, but I do remember that "strip --nobackup" was changed to
"strip --no-backup" to be consistent with revert, rather than the
other way around. So I think hyphens are OK in options. Just not
necessary in this case.

> > Tests?
> 
> I thought that I could not run the tests on Windows, which is my only
> development environment (I am using hackable mercurial 2.1). However
> http://mercurial.selenic.com/wiki/HackableMercurial implies that it
> should be possible to run part of the test suite now (although the
> setting it up seems a bit complicated).
> 
> Do you know if the patchbomb tests can be run on Windows?

No idea. Why don't you try it and let us know? My recollection is that
test-patchbomb.t uses "-n" for every test, and just asserts that the
textual output is correct. Testing a complete email system would be
challenging on any platform.

        Greg
-- 
Greg Ward                                http://www.gerg.ca/
Know thyself.  If you need help, call the CIA.


More information about the Mercurial-devel mailing list