[PATCH RFC STABLE?] dirstate: catch non-32-bit-safe mtime and file size early (issue2608)

[Mads Kiilerich]

Greg Ward wrote, On 03/22/2012 01:38 AM:
> # HG changeset patch
> # User Greg Ward<greg at gerg.ca>
> # Date 1329327653 18000
> # Branch stable
> # Node ID 354794e7bf7fd4713bd5f46ce9770c7ae1b4f7ad
> # Parent  9670e0c88deee8dcfe45ddb3010696928b835fec
> dirstate: catch non-32-bit-safe mtime and file size early (issue2608).
>
> Rather than blow up late in the game, after we've already committed
> and are just trying to write the dirstate, catch it much earlier. Then
> we avoid putting the working dir in a bad state (dirstate does not
> reflect commit), and it's also quite obvious that the problem is that
> some file has blown one of the 32-bit limits in dirstate.
>
> Error messages need work. Commence bikeshedding at will. ;-)

It has previously been proposed that we just could store the lower bits 
of the file size in the dirstate. That should be sufficiently safe for 
most real world usage.

Something similar could perhaps be done with the time stamp.

/Mads