[PATCH] phases: fix a non-standard debug message

Greg Ward greg at gerg.ca
Thu Mar 29 14:27:21 CDT 2012


On 27 March 2012, Matt Mackall said:
> On Wed, 2012-03-21 at 20:36 -0400, Greg Ward wrote:
> > # HG changeset patch
> > # User Greg Ward <greg at gerg.ca>
> > # Date 1329345021 18000
> > # Branch stable
> > # Node ID 9670e0c88deee8dcfe45ddb3010696928b835fec
> > # Parent  2338ab19b23690e74e1ba3936667399dfeb9490c
> > phases: fix a non-standard debug message
> > - add missing newline
> > - ditch gratuitous use of string formatting with dict
> > - fix so it actually does string formatting ('%' rather than ',')
> > - inline unnecessary local variable
> > - downcase first word
> 
> Queued for stable. Can I interest you in trying to add check-code checks
> for some of these?

Hmmm. OK, sure, what the heck, I'll give it a shot.

[Pierre-Yves]
> How did you catch it ?
> 
> Did you corrupt your phase file for real ? If so, how ?

I don't remember. It was weeks and weeks ago, and I was mucking about
it in something else entirely. I do remember that my first actual
interaction with phases (rather than seeing your patches fly by) was
this wonky debug message, and I was sufficiently irritated that I
fixed it right then and there ... and then forgot to email the fix
until the other day.

       Greg


More information about the Mercurial-devel mailing list