import --no-commit and rollback

Matt Mackall mpm at selenic.com
Thu Mar 29 15:38:57 CDT 2012


On Thu, 2012-03-29 at 22:36 +0200, Andreas Bernauer wrote:
> On 3/20/12 13:51, Greg Ward wrote:
> >> # HG changeset patch
> >> # User Andreas Bernauer <ab-mercurial at lysium.de>
> >> # Date 1331895009 -3600
> >> # Node ID 2522c89cb7ab2b9ee7aaa525eecb2b54f70065d6
> >> # Parent  7b9bf72430bab927974f4e9404880271e3dbd2e6
> >> Don't create transaction when import with '--no-commit' (issue3323)
> > 
> > I think the patch looks great. The only thing missing is to format the
> > commit message according to Matt's exacting standards. I suggest:
> > 
> >   import: don't create a transaction with '--no-commit' (issue3323)
> > 
> > Oh yeah: tests. This is definitely testable. I suspect simply running
> > "hg rollback -n" after one of the "hg import --no-commit" calls in
> > tests/test-import.t will reveal the bug and allow you to assert that
> > you have fixed it. I see that there is already code in test-import.t
> > to ensure rollback after regular import works, so that should catch
> > you if you break that feature. 
> 
> I think the issue has been fixed in changeset 5d75eb8568d1, albeit
> without tests and with an unrelated commit message.

Doh. Always check status before qnew.

-- 
Mathematics is the supreme nostalgia of our time.




More information about the Mercurial-devel mailing list