[PATCH STABLE V2] largefiles: make archive -S store largefiles instead of standins

Martin Geisler mg at aragost.com
Fri May 4 05:26:15 CDT 2012


Matt Harbison <matt_harbison at yahoo.com> writes:

> # HG changeset patch
> # User Matt Harbison <matt_harbison at yahoo.com>
> # Date 1336095177 14400
> # Branch stable
> # Node ID 439e3edfddcef0a0c59462f9d1c5f5b3385ed9cd
> # Parent  91323a78aac252b630144f66e1039321cd41c9ef
> largefiles: make archive -S store largefiles instead of standins

Thanks, this looks good to me, it's pushed as 43fb170a23bd.

> This is essentially a copy of largefile's override of archive() in the
> archival class, adapted for overriding hgsubrepo's archive(). That
> means decoding isn't taken into consideration, nor is .hg_archival.txt
> generated (the same goes for regular subrepos). Unlike subrepos, but
> consistent with largefile's handling of the top repo, ui.progress() is
> *not* called. This should probably be refactored at some point, but at
> least this generates the archives properly for now. Previously, the
> standins were ignored and the largefiles were archived only for the
> top level repo.
>
> Long term, it would probably be most desirable to figure out how to
> tweak archival's archive() if necessary such that largefiles doesn't
> need to override it completely just to special case the translating of
> standins to the real files. Largefiles will already return a context
> with the true largefiles instead of the standins if lfilesrepo's
> lfstatus is True- perhaps this can be leveraged?

Feel free to send more patches if you (or maybe Na'Tosha) do any
followup refactoring.

-- 
Martin Geisler

aragost Trifork
Commercial Mercurial support
http://aragost.com/mercurial/


More information about the Mercurial-devel mailing list