[PATCH] Optimize node-to-node localrepo.status
Matt Mackall
mpm at selenic.com
Fri May 4 13:50:44 CDT 2012
On Fri, 2012-05-04 at 14:28 -0400, Jesse Glick wrote:
> On 05/04/2012 01:27 PM, Matt Mackall wrote:
> > See bulletpoint 3 here:
>
> You mean "include relevant test changes"? I am not sure what those would be; the existing tests pass and this is just an optimization.
You might want to check that you're running the latest version of your
browser, it's apparently buggy. I meant:
* first line of commit message is of the form "subsystem: uncapitalized,
no trailing period"
This made much more sense in context, let's restore that:
# HG changeset patch
# User Jesse Glick <jesse.glick at oracle.com>
# Date 1336007415 14400
# Branch stable
# Node ID 419630251325c7d081fddd48e816da2cfaaaae51
# Parent 979b1b7340fba32b4d7f499e6d89093758147520
Optimize node-to-node localrepo.status.
According to the above, there are three things wrong here.
> By the way do you prefer the OO style in the existing patch, or a direct call to isinstance(match, matchmod.always)?
The current style is better.
--
Mathematics is the supreme nostalgia of our time.
More information about the Mercurial-devel
mailing list