[PATCH] tests: test-ui-color.py fails from a dumb terminal

[Jesse Glick]

On 05/04/2012 05:50 PM, Matt Mackall wrote:
>> Need to skip in this environment
>
> I think run-tests should either eliminate or standardize the TERM
> variable instead?

Not sure. What would it be standardized to? The code line in question seems to be

   formatted = always or (os.environ.get('TERM') != 'dumb' and ui.formatted())

but then other OS-specific code follows, and it is not completely clear to me what the expectations of the test's author were so I was just disabling the test when it 
definitely failed before. I could alter the test to change TERM=dumb to TERM=arbitrary, or remove the variable, either of which seems to make it pass. Standardizing TERM 
to some value in run-tests might interfere with unrelated tests, and perhaps test-ui-color.py was supposed to be following a different code path when run from cmd.exe or 
the like?