About an IRC discussion on using pull requests for hg development

David Soria Parra dsp at php.net
Tue May 8 06:55:23 CDT 2012


On 2012-05-07, Matt Mackall <mpm at selenic.com> wrote:
> On Mon, 2012-05-07 at 18:33 +0200, Patrick M?zard wrote:
> Every time this comes up, I say "but I do accept pull requests!"
>
> But I only want pull requests from people who have a track record of
> getting a submission right the first time and have internalized
> important rules like "don't mix unrelated changes". Otherwise I'll start
> reading your incoming csets, discover problems, then ask you to resend
> so I can comment on the problems. Which means my aborted first pass was
> wasted effort.
>
> I also regularly pull from the crew and i18n trees. The former is full
> of trusted committers, the latter is effectively unreviewable.
>
> And as it happens, most of the people I'd accept a pull request from
> either have crew access or are content to patchbomb (or both!).

btw I had both Matt and Crew pulling from me in a few occasions. As
Matt says, you can always open a pull request. Also it's not
Matt that has to accept it, it's perfectly fine to have a Crew
member pull. Benoit pulled from me for a few times. That way
we get a nice "web of trust". The only thing that went wrong
in the past is that people pulling used --rebase breaking
the contributors repository.

I would just advice to try open pull request instead of trying
to redo the general workflow.



More information about the Mercurial-devel mailing list