[issue3439] hgweb throwing OSError on failing unlink

[benallard]

New submission from benallard <benoit at aeteurope.nl>:

Running hg 2.2.1, through mod_wsgi on apache on a Debian lenny system.

This is what came in my error.log:

URL: https://usl/to/repository/?cmd=unbundle
 File 'paste/exceptions/errormiddleware.py', line 144 in __call__
 File 'usr/local/lib/python2.5/site-
packages/mercurial/hgweb/hgwebdir_mod.py', line 147 in __call__
   return self.run_wsgi(req)
 File 'usr/local/lib/python2.5/site-
packages/mercurial/hgweb/hgwebdir_mod.py', line 205 in run_wsgi
   return hgweb(repo).run_wsgi(req)
 File 'usr/local/lib/python2.5/site-packages/mercurial/hgweb/hgweb_mod.py', 
line 127 in run_wsgi
   return protocol.call(self.repo, req, cmd)
 File 'usr/local/lib/python2.5/site-packages/mercurial/hgweb/protocol.py', 
line 76 in call
   rsp = wireproto.dispatch(repo, p, cmd)
 File 'usr/local/lib/python2.5/site-packages/mercurial/wireproto.py', line 
348 in dispatch
   return func(repo, proto, *args)
 File 'usr/local/lib/python2.5/site-packages/mercurial/wireproto.py', line 
596 in unbundle
   os.unlink(tempname)
 OSError: [Errno 2] No such file or directory: '/tmp/hg-unbundle-qa5O8S'

Indeed the unlink appears inside the finally clause. So the exception is not 
caught.

----------
messages: 19985
nosy: benallard
priority: bug
status: unread
title: hgweb throwing OSError on failing unlink
topic: wire

____________________________________________________
Mercurial issue tracker <bugs at mercurial.selenic.com>
<http://mercurial.selenic.com/bts/issue3439>
____________________________________________________