[PATCH 4 of 4] mq: introduce mq.check setting

Angel Ezquerra angel.ezquerra at gmail.com
Sat May 12 03:37:57 CDT 2012


On May 12, 2012 10:09 AM, "Matt Mackall" <mpm at selenic.com> wrote:
>
> On Sat, 2012-05-12 at 01:12 +0200, Patrick Mezard wrote:
> > # HG changeset patch
> > # User Patrick Mezard <patrick at mezard.eu>
> > # Date 1336774770 -7200
> > # Node ID ed81cb27341e285d539617ba961f48c69dd18135
> > # Parent  f4da2aeb000408aa54f59829acb092ec85914475
> > mq: introduce mq.check setting
>
> Nice, these are queued for default.

Patrick,

I'm curious, why did you choose "check" as the name for this option? It
does not seem obvious to me...

Also I'm a bit surprised that the backward compatibility rule applies here,
given that this simply lets you do things that before would simply fail. As
you said in your commit message this is probably the behavior expected by
most users.

I didn't look too carefully at your patch, so maybe you already did that,
but wouldn't it make sense to mention this new option on the error message
that is shown if you don't use this option?

Cheers,

Angel

Angel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://selenic.com/pipermail/mercurial-devel/attachments/20120512/2fc12ce3/attachment.html>


More information about the Mercurial-devel mailing list