[PATCH 1 of 3 resend] parsers: allow hex keys
Bryan O'Sullivan
bos at serpentine.com
Sat May 12 03:57:15 CDT 2012
# HG changeset patch
# User Bryan O'Sullivan <bryano at fb.com>
# Date 1336812907 -7200
# Node ID 95dcb9aa70aff9a96a851682a4bd5ff244692fc7
# Parent 68e343652bc97f5c34c57e4622fddd94b83beb9c
parsers: allow hex keys
diff -r 68e343652bc9 -r 95dcb9aa70af mercurial/parsers.c
--- a/mercurial/parsers.c Sat May 12 10:55:06 2012 +0200
+++ b/mercurial/parsers.c Sat May 12 10:55:07 2012 +0200
@@ -553,8 +553,10 @@
* -2: not found
* rest: valid rev
*/
-static int nt_find(indexObject *self, const char *node, Py_ssize_t nodelen)
+static int nt_find(indexObject *self, const char *node, Py_ssize_t nodelen,
+ int hex)
{
+ int (*getnybble)(const char *, Py_ssize_t) = hex ? hexdigit : nt_level;
int level, maxlevel, off;
if (nodelen == 20 && node[0] == '\0' && memcmp(node, nullid, 20) == 0)
@@ -563,21 +565,28 @@
if (self->nt == NULL)
return -2;
- maxlevel = nodelen > 20 ? 40 : ((int)nodelen * 2);
+ if (hex)
+ maxlevel = nodelen > 40 ? 40 : nodelen;
+ else
+ maxlevel = nodelen > 20 ? 40 : ((int)nodelen * 2);
for (level = off = 0; level < maxlevel; level++) {
- int k = nt_level(node, level);
+ int k = getnybble(node, level);
nodetree *n = &self->nt[off];
int v = n->children[k];
if (v < 0) {
const char *n;
+ Py_ssize_t i;
+
v = -v - 1;
n = index_node(self, v);
if (n == NULL)
return -2;
- return memcmp(node, n, nodelen > 20 ? 20 : nodelen)
- ? -2 : v;
+ for (i = level; i < maxlevel; i++)
+ if (getnybble(node, i) != nt_level(n, i))
+ return -2;
+ return v;
}
if (v == 0)
return -2;
@@ -679,7 +688,7 @@
int rev;
self->ntlookups++;
- rev = nt_find(self, node, nodelen);
+ rev = nt_find(self, node, nodelen, 0);
if (rev >= -1)
return rev;
More information about the Mercurial-devel
mailing list