[PATCH 4 of 4] mq: introduce mq.check setting

[Patrick Mézard]

Le 12/05/12 10:37, Angel Ezquerra a écrit :
> On May 12, 2012 10:09 AM, "Matt Mackall" <mpm at selenic.com> wrote:
>>
>> On Sat, 2012-05-12 at 01:12 +0200, Patrick Mezard wrote:
>>> # HG changeset patch
>>> # User Patrick Mezard <patrick at mezard.eu>
>>> # Date 1336774770 -7200
>>> # Node ID ed81cb27341e285d539617ba961f48c69dd18135
>>> # Parent  f4da2aeb000408aa54f59829acb092ec85914475
>>> mq: introduce mq.check setting
>>
>> Nice, these are queued for default.
> 
> Patrick,
> 
> I'm curious, why did you choose "check" as the name for this option? It
> does not seem obvious to me...

I have not given much thought to it. --check makes it sound like qpush/qpop will closely "check" the local changes before deciding to bail out or not. The setting is named after the command line option. Maybe this is a mistake, if you have something better to suggest, feel free to submit a patch, that is exactly the right time to change it.

> Also I'm a bit surprised that the backward compatibility rule applies here,
> given that this simply lets you do things that before would simply fail. As
> you said in your commit message this is probably the behavior expected by
> most users.

See http://selenic.com/hg/rev/e9ed3506f066 for the qpush attempt.

> I didn't look too carefully at your patch, so maybe you already did that,
> but wouldn't it make sense to mention this new option on the error message
> that is shown if you don't use this option?

Certainly, anything to make it (more) discoverable would be great. The setting should be mentioned in qpush/qpop/qgoto help as well.

--
Patrick Mézard