[Bug 3444] New: lfconvert violates locking

[bugzilla-daemon at bz.selenic.com]

http://bz.selenic.com/show_bug.cgi?id=3444

          Priority: meh
            Bug ID: 3444
                CC: mercurial-devel at selenic.com
          Assignee: mercurial-devel at selenic.com
           Summary: lfconvert violates locking
          Severity: bug
    Classification: Unclassified
                OS: All
          Reporter: natosha at gmail.com
          Hardware: All
            Status: UNCONFIRMED
           Version: unspecified
         Component: Mercurial
           Product: Mercurial

According to http://mercurial.selenic.com/wiki/LockingDesign we need to be
locking on wlock whenever we manipulate the dirstate.

In lfcommands.lfconvert, we don't do this.  If you change lfconvert to obtain
the wlock (in addition to the lock), the lfconvert test fails -- seemingly
after having tried to convert a repository with bad tags.

So far I am at a loss as for why or how to improve the situation.  I've traced
it down to

rdst.setparents(ret)

inside of lfcommands._getchangedfiles() -- if the wlock is obtained (by anyone)
while this method is run, the test fails.  If the wlock is not obtained, then
the test passes, but this seems incorrect.

-- 
You are receiving this mail because:
You are the assignee for the bug.