[PATCH 2 of 2] bdiff: check and cast first parameter value on putbe32() calls

Adrian Buehlmann adrian at cadifra.com
Tue May 15 16:03:20 CDT 2012


On 2012-05-15 22:41, Adrian Buehlmann wrote:
> # HG changeset patch
> # User Adrian Buehlmann <adrian at cadifra.com>
> # Date 1337114207 -7200
> # Node ID 2ce44c7022096445ec681b27200137740924701a
> # Parent  db0b25613afdeec4573288e8390ec0dd01981436
> bdiff: check and cast first parameter value on putbe32() calls

Also tested on Windows 7 x64 with x64 Python 2.6.6 (extensions compiled
with MS compiler) with the testsuite running on MSYS:

  $ python run-tests.py --local
  ...
  Failed test-commandserver.py: output changed
  Failed test-mq-strip.t: output changed
  # Ran 285 tests, 154 skipped, 2 failed.

The failing tests are unrelated:

The mq-strip.t failure has already been reported by the build bot (seems
to first appear on "(3290e24bb3f0) strip: introduce -B option to remove
a bookmark")

test-commandserver.py fails without my patches:

$ python run-tests.py --local
.....s.ss.ss.s...s....s....s.........s.s..s..s..sss...s
--- c:\users\adi\hgrepos\hg-main\tests\test-commandserver.py.out
+++ c:\users\adi\hgrepos\hg-main\tests\test-commandserver.py.err
@@ -87,9 +87,7 @@
 testing hookoutput:

  runcommand --config hooks.pre-identify=python:test-commandserver.hook id
-hook talking
-now try to read something: 'some input'
-eff892de26ec tip
+abort: pre-identify hook is invalid (import of "test-commandserver" failed)

 testing outsidechanges:


ERROR: c:\users\adi\hgrepos\hg-main\tests\test-commandserver.py output
changed


More information about the Mercurial-devel mailing list