[PATCH v2] bookmarks: pull new bookmarks from remote by default

Matt Mackall mpm at selenic.com
Tue May 15 17:18:51 CDT 2012


On Mon, 2012-05-14 at 16:18 -0500, Kevin Bullock wrote:
> On 14 May 2012, at 3:09 PM, Augie Fackler wrote:
> 
> > On May 14, 2012, at 7:43 PM, Kevin Bullock wrote:
> > 
> > > On May 12, 2012, at 10:24 AM, Matt Mackall wrote:
> > > 
> > > > On Sat, 2012-05-12 at 17:02 +0200, Levi Bard wrote:
> > > > > # HG changeset patch
> > > > > # User Levi Bard <levi at unity3d.com>
> > > > > # Date 1336834801 -7200
> > > > > # Node ID c3fe1f84a74161cd84ab2c85d78985429fed69c2
> > > > > # Parent  76c744e0c5bbd0900beba49787b7e04ba862939b
> > > > > bookmarks: pull new bookmarks from remote by default
> > > > 
> > > > Queued for default, thanks.
> > > 
> > > 
> > > What's the rationale for this? Does no one use non-shared
> > > bookmarks anymore?
> > 
> > The rationale is that pulling from a server with bookmarks probably
> > indicates that you want those bookmarks locally (e.g. pulling from
> > mom's repo). Pushing still only happens explicitly unless a bookmark
> > of the same name exists.
> > 
> 
> 
> And what about when the "server" is a repo in which I happened to fire
> up `hg serve` to share some changes with a coworker? In that case I
> can't imagine they'd want all my random little markers littering their
> repo.

On the other hand, they -will- get your random little _csets_ littering
their repo, so getting the corresponding bookmarks to go with them seems
appropriate. This more or less brings pull into alignment with clone's
behavior.

(Admittedly, this is a fairly radical change relative to our usual
conservative approach. But we're still trying to get this bookmark stuff
to fully gel.)

-- 
Mathematics is the supreme nostalgia of our time.




More information about the Mercurial-devel mailing list