[PATCH 0 of 2] help: RST formatting

Matt Mackall mpm at selenic.com
Thu May 17 10:59:06 CDT 2012


On Thu, 2012-05-17 at 17:14 +0200, Olav Reinert wrote:
> These patches implement formatting of all help text using RST.  Both console
> and web help use RST to format all output. Web help remains as preformatted
> text, instead of proper HTML, for now. No functionality is changed, but some
> help text appears differently:
> 
> 
> 1) The first column of Field lists are now always 14 characters wide.

Why? This sounds suspiciously like an "unrelated change".

Patch two is still way too big to review. One measure of its
unreviewability: I can't easily spot where in the patch the '14' is
introduced.

As both Martin and I have already hinted, this work really wants to be
at least four patches (if not more). 

I have to drop the first one too, as I now have no confidence that
you've internalized "don't make unrelated changes" and I have no
convenient way of confirming that you've just moved the code without
sneaking in tweaks.

-- 
Mathematics is the supreme nostalgia of our time.




More information about the Mercurial-devel mailing list