[PATCH 0 of 2] help: RST formatting

Adrian Buehlmann adrian at cadifra.com
Sun May 20 13:49:01 CDT 2012


On 2012-05-18 00:08, Olav Reinert wrote:
> On 17. maj 2012, at 17.59, Matt Mackall wrote:
>> On Thu, 2012-05-17 at 17:14 +0200, Olav Reinert wrote:
>>> 1) The first column of Field lists are now always 14 characters wide.
>>
>> Why? This sounds suspiciously like an "unrelated change".
> 
> It happens due to the following:
> 
> 1) I chose to format the command lists using RST field list markup, because it most closely resembles the original format:
> 
> http://docutils.sourceforge.net/docs/user/rst/quickref.html#field-lists
> 
> 2) minirst always formats field lists with a first column 14 characters wide due to this change:
> 
> http://markmail.org/message/krl4cxopsnii7s6z
> 
> Some markup had to be chosen to achieve two-column output, and other options seemed even more intrusive.
> I don't consider this an unrelated change.

This explanation should go into the change message of the second patch.

Together with the note "The first column of Field lists are now always
14 characters wide".

>> I have to drop the first one too, as I now have no confidence that
>> you've internalized "don't make unrelated changes" and I have no
>> convenient way of confirming that you've just moved the code without
>> sneaking in tweaks.
> 
> Not even the fact that it makes no changes to any test cases, yet passes all of them, is enough to convince you of that?


More information about the Mercurial-devel mailing list