[PATCH 0 of 1 stable 3] accept long as revs

Sune Foldager cryo at cyanite.org
Mon May 21 09:36:56 CDT 2012


On 2012-05-21 09:28, Matt Mackall wrote:
>On Mon, 2012-05-21 at 15:23 +0200, Sune Foldager wrote:
>> Since the index is no longer an array (is there a document about the design of the
>> new ADT somewhere?), I had to change the C code to make this work. Note that if we
>> don't take this patch, since some places do accept long, I bet it will fail in the
>> C code (with the weird message "expected string or Unicode. Got long").
>
>Whoa whoa whoa. I thought we were talking about a one-liner in
>context.py.
>
>Again, using a long here is utterly bogus and misguided. Catching it in
>one central place is acceptable, letting that nonsense ripple down into
>the C code is not.

Also, there is central place.

-Sune


More information about the Mercurial-devel mailing list